-
Notifications
You must be signed in to change notification settings - Fork 257
[query] use log4j2 #15176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[query] use log4j2 #15176
+93
−337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
71be1cd to
e215e19
Compare
1849ac0 to
7d9a51a
Compare
This was referenced Nov 5, 2025
e215e19 to
349270e
Compare
7d9a51a to
fb70546
Compare
349270e to
49de5d0
Compare
fb70546 to
48f939c
Compare
928f7e9 to
f5248ee
Compare
49de5d0 to
a37d752
Compare
f5248ee to
54fcb8a
Compare
a37d752 to
7793d61
Compare
c94c16c to
d6bda61
Compare
d6bda61 to
4e4348c
Compare
4e4348c to
72e7d4b
Compare
72e7d4b to
e4b2ab2
Compare
chrisvittal
approved these changes
Nov 13, 2025
Collaborator
chrisvittal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much more sane. Thank you for this.
patrick-schultz
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

I believe the spark version bump switched the runtime logging implementation to log4j core v2. This broke our py4j logging configuration tacitly. After switching over to v2 I discovered that we don't need things like the
StringSocketAppender because we're redirecting the jvm's stderr to python.We use the hail jar in a few situations with slightly different requirements - tests, py4j, py4j in batch and qob:
This is what
Py4jUtils.configureLogging attempts to address: when binging to apy4j gateway, we need to reconfigure the logging configuration so we can forward logs to stderr and write to our logfile.Note that the configuration contains a spark logger - the logs are quite noisy and adding this allows us to control how much noise we want from spark.
This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP